add more information when service.platform isn't part of service.build.platforms
#9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkielbasa can you sign-off your commit? Just follow the instructions here |
glours
reviewed
Sep 23, 2022
|
@bkielbasa you need to rebase your branch and update the e2e tests as I mentioned before, otherwise we're almost ready to merge it! |
|
@glours thanks for your review! I updated tests so it should be ready to go! |
glours
requested changes
Sep 26, 2022
…d.platforms Signed-off-by: Bartłomiej Klimczak <bartlomiej.klimczak88@gmail.com>
Signed-off-by: Bartłomiej Klimczak <bartlomiej.klimczak88@gmail.com>
|
@glours done! Sorry, I mess up with rebase :) it should be fine now |
glours
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I found it a bit problematic to debug so I added a bit more detailed error messages when
service.platformisn't part ofservice.build.platforms.