Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to convert strings to bool #9230

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add function to convert strings to bool #9230

merged 1 commit into from
Mar 4, 2022

Conversation

ulyssessouza
Copy link
Collaborator

What I did
Add function to convert strings to bool
Typically used on boolean environment variable values

@ulyssessouza
Add function to convert strings to bool
67b4669 
Typically used on boolean environment variable values

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
@ulyssessouza ulyssessouza force-pushed the treat-env-bool-vars branch from b55b2c2 to 67b4669 Compare March 4, 2022 15:43
@ulyssessouza ulyssessouza requested review from glours and ndeloof March 4, 2022 15:47
@ulyssessouza ulyssessouza marked this pull request as ready for review March 4, 2022 15:47
glours
glours approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 1a4e6c2 into docker:v2 Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulyssessouza @glours