Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NetworkMode correctly according to network priorities #9130

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

laurazard
Copy link
Contributor

Signed-off-by: Laura Brehm laurabrehm@hey.com

What I did
Sets NetworkMode according to network priority on container create call

Related issue
Fixes #9076

@laurazard laurazard force-pushed the fix_mac_address_network_priority branch from a763b6f to 0aad277 Compare January 28, 2022 14:45
@laurazard laurazard marked this pull request as draft January 28, 2022 15:29
Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard laurazard force-pushed the fix_mac_address_network_priority branch from 0aad277 to 4a2cb45 Compare January 31, 2022 16:15
@laurazard laurazard marked this pull request as ready for review January 31, 2022 18:49
pkg/compose/create.go Outdated Show resolved Hide resolved
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@laurazard laurazard force-pushed the fix_mac_address_network_priority branch from 4a2cb45 to a483639 Compare February 1, 2022 12:59
@ulyssessouza ulyssessouza merged commit 5262d3b into docker:v2 Feb 1, 2022
@laurazard laurazard deleted the fix_mac_address_network_priority branch May 21, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using mac_address with multiple networks is unreliable in Compose V2
3 participants