Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't SetRawTerminal() when exec is run with -T #9113

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

x-yuri
Copy link
Contributor

@x-yuri x-yuri commented Jan 18, 2022

What I did

Made it not put the terminal into raw mode.

Related issue

Fixes #9086.

(not mandatory) A picture of a cute animal, if possible in relation with what you did

https://giphy.com/gifs/cW64pEEZe0YZa

@ndeloof
Copy link
Contributor

ndeloof commented Jan 18, 2022

For legal reasons we require commits to be signed-off.
please git commit --amend --sign-off on your branch then push --force so I can merge

Signed-off-by: Yuri Kanivetsky <yuri.kanivetsky@gmail.com>
@x-yuri
Copy link
Contributor Author

x-yuri commented Jan 18, 2022

@ndeloof I think I've done. By the way, --signoff, at least in my git.

@ndeloof ndeloof merged commit 37f763f into docker:v2 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken output with disabled pseudo-tty allocation
2 participants