Ignore command names on NoSuchCommand exceptions #8261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2053472 to
e5cab3c
Compare
gtardif
reviewed
Apr 8, 2021
gtardif
reviewed
Apr 8, 2021
| @@ -36,7 +36,7 @@ def __init__(self, command, | |||
| context_type=None, status=Status.SUCCESS, | |||
| source=MetricsSource.CLI, uri=None): | |||
| super().__init__() | |||
| self.command = "compose " + command if command else "compose --help" | |||
| self.command = ("compose " + command).strip() if command else "compose --help" | |||
There was a problem hiding this comment.
I suppose this is to leave self.command = "compose" value in case of NoSuchCommand exception (when command = "") ?
There was a problem hiding this comment.
Yes. In the case of NoSuchCommand the variable will have an empty string leaving a trailing space on the final string. The strip() is to remove it in this case.
aiordache
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/docker/dev-tooling-team/issues/298