Allow setting a one-off container name #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c2bd00 to
95b6227
Compare
| @@ -99,14 +99,12 @@ def test_get_volumes_from_service_no_container(self): | |||
|
|
|||
| def test_split_domainname_none(self): | |||
| service = Service('foo', image='foo', hostname='name', client=self.mock_client) | |||
| self.mock_client.containers.return_value = [] | |||
There was a problem hiding this comment.
These mock return values haven't been necessary for a while, since we refactored _get_container_create_options() to not make any api calls.
There was a problem hiding this comment.
Nice. Sorry to be picky, but would you mind doing this cleanup (and the __ -> _ changes) in a separate commit?
…ndard single underscore for unused variable Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
95b6227 to
d2718be
Compare
|
Split into 2 commits, cleanup then actual feature |
|
LGTM |
aanand
added a commit
that referenced
this pull request
Aug 26, 2015
Allow setting a one-off container name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1755 we removed the custom name from one-off containers, which left them with the default name.
This adds a
--nameparam todocker-compose runto name the container