Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/docker/docker e622cea55698 (master / v27.0.0-dev) #5100

Merged
merged 3 commits into from
May 31, 2024

Conversation

thaJeztah
Copy link
Member

vendor: github.com/opencontainers/image-spec v1.1.0

full diff: opencontainers/image-spec@v1.1.0-rc5...v1.1.0

vendor: github.com/Microsoft/hcsshim v0.11.5

full diff: microsoft/hcsshim@v0.11.4...v0.11.5

vendor: github.com/docker/docker e622cea55698 (master / v27.0.0-dev)

full diff: moby/moby@06e3a49...e622cea

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah added 2 commits May 31, 2024 16:10
full diff: opencontainers/image-spec@v1.1.0-rc5...v1.1.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: microsoft/hcsshim@v0.11.4...v0.11.5

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Collaborator

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks like there's some linters complaining)

full diff: moby/moby@06e3a49...e622cea

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Thanks! Missed one lint failure indeed; should be fixed now

68.87 cli/command/service/update.go:1326:10: import-shadowing: The name 'network' shadows an import name (revive)
68.87 		for _, network := range networks {
68.87 		       ^

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 61.35%. Comparing base (cd4d62e) to head (e2fc6bd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5100      +/-   ##
==========================================
- Coverage   61.37%   61.35%   -0.03%     
==========================================
  Files         298      295       -3     
  Lines       20718    20713       -5     
==========================================
- Hits        12716    12708       -8     
- Misses       7102     7103       +1     
- Partials      900      902       +2     

@thaJeztah
Copy link
Member Author

Thanks Silvin!

@thaJeztah thaJeztah merged commit 1a8fa8b into docker:master May 31, 2024
88 checks passed
@thaJeztah thaJeztah deleted the bump_engine branch May 31, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants