Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for docker stack config #3577

Merged
merged 2 commits into from
Apr 30, 2022

Conversation

albers
Copy link
Collaborator

@albers albers commented Apr 29, 2022

This adds bash completion for #3544.
Also removes the unsupported alias docker stack cfg from help output.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #3577 (381fb1d) into master (1497633) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3577   +/-   ##
=======================================
  Coverage   59.36%   59.36%           
=======================================
  Files         287      287           
  Lines       24175    24175           
=======================================
  Hits        14352    14352           
  Misses       8958     8958           
  Partials      865      865           

This adds bash completion for docker#3544.

Signed-off-by: Harald Albers <github@albersweb.de>
@albers albers force-pushed the completion-stack-config branch from cb15d42 to e4381ee Compare April 29, 2022 19:32
Signed-off-by: Harald Albers <github@albersweb.de>
@albers albers force-pushed the completion-stack-config branch from e4381ee to 381fb1d Compare April 29, 2022 20:19
@albers
Copy link
Collaborator Author

albers commented Apr 29, 2022

I got no idea how the failures in test / host (macos-latest) should be related to this PR.
Can someone please help?

@thaJeztah thaJeztah added this to the 22.04.0 milestone Apr 30, 2022
@thaJeztah
Copy link
Member

Thanks! I completely forgot the completion this time (I recall looking at it when rebasing, but forgot to follow up 😞)

I got no idea how the failures in test / host (macos-latest) should be related to this PR.
Can someone please help?

Let me restart that one; it's known to be flaky; see #3554 (and #3573 for a workaround that's being worked on)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaJeztah
Copy link
Member

all green now 👍

@thaJeztah thaJeztah merged commit 49c56da into docker:master Apr 30, 2022
@albers albers deleted the completion-stack-config branch April 30, 2022 18:26
@docker docker deleted a comment from Leopere Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants