Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03 backport] completion script updates and fixes #2176

Merged
merged 7 commits into from
Oct 29, 2019
Merged

[19.03 backport] completion script updates and fixes #2176

merged 7 commits into from
Oct 29, 2019

Conversation

thaJeztah
Copy link
Member

backports of:

sanga and others added 7 commits October 29, 2019 15:10
@sanga @thaJeztah
add rudimentary fish completions for docker network
6c66c79 
Signed-off-by: Tim Sampson <tim@sampson.fi>
(cherry picked from commit 2f7b364)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@artheus-sbab @thaJeztah
Make service completion faster
667bd9a 
Signed-off-by: Morten Hekkvang <morten.hekkvang@sbab.se>
(cherry picked from commit f55c5b6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@artheus-sbab @thaJeztah
Fix substitution of comma to space character, suggested by @albers
c70ce79 
Signed-off-by: Morten Hekkvang <morten.hekkvang@sbab.se>
(cherry picked from commit b85e1e2)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@artheus-sbab @thaJeztah
Move filtering to __docker_complete_services, as suggested by @albers
9447d74 
Signed-off-by: Morten Hekkvang <morten.hekkvang@sbab.se>
(cherry picked from commit 6ebcc21)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Fix erroneous space indentation of shell script
69f0132 
Signed-off-by: Morten Hekkvang <morten.hekkvang@sbab.se>
(cherry picked from commit fc19fb6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Add bash completion for builder build
2fe281d 
Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
(cherry picked from commit 86ae871)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add bash completion for builder build options
57332bc 
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit cd9b39f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.5 milestone Oct 29, 2019
@thaJeztah thaJeztah requested a review from albers as a code owner October 29, 2019 14:13
@thaJeztah
Copy link
Member Author

@silvin-lubecki @albers @andrewhsu ptal

kolyshkin
kolyshkin reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 5cef8fc into docker:19.03 Oct 29, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_completion branch October 29, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin kolyshkin left review comments

@albers albers Awaiting requested review from albers albers is a code owner

Assignees
No one assigned
Labels
area/completion status/2-code-review
Projects
None yet
Milestone
19.03.5
Development

Successfully merging this pull request may close these issues.
7 participants
@thaJeztah @kolyshkin @andrewhsu @GordonTheTurtle @sanga @artheus-sbab @albers