Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating deprecated command example in search.md #2072

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

danielartine
Copy link
Contributor

- What I did

- How I did it

- How to verify it

- Description for the changelog
The current example uses --stars flag (deprecated). Changed to --filter=stars to use the right syntax.

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:danielartine/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

--stars example is deprecated. Changing to --filter=stars=5

Signed-off-by: danielartine <daniel.artine@ufrj.br>
@codecov-io
Copy link

Codecov Report

Merging #2072 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files         311      311           
  Lines       21836    21836           
=======================================
  Hits        12400    12400           
  Misses       8520     8520           
  Partials      916      916

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 58153b2 into docker:master Aug 29, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants