fix(pull_test): --quiet option #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teppei Fukuda <knqyf263@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2069 +/- ##
==========================================
+ Coverage 56.78% 56.79% +<.01%
==========================================
Files 311 311
Lines 21836 21836
==========================================
+ Hits 12400 12402 +2
+ Misses 8520 8519 -1
+ Partials 916 915 -1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2069 +/- ##
==========================================
+ Coverage 56.78% 56.79% +<.01%
==========================================
Files 311 311
Lines 21836 21836
==========================================
+ Hits 12400 12402 +2
+ Misses 8520 8519 -1
+ Partials 916 915 -1 |
thaJeztah
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
LGTM
nice find; looks like I spotted the issue in #882 (comment), but thought it was fixed in the test, but actually the .golden file was update to match the wrong output 😞 😅
Blame me for not spotting that in my final review 🤗
|
ping @vdemeester PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test of "docker pull --quiet"