build: set the frontend attributes for callfunc earlier #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend attributes that were set when `CallFunc` was set were not set early enough and it prevented buildkit from seeing the `requestid`. The `requestid` would only be seen by the `LLBBridgeClient` and it was not set yet when the `Controller.Solve` method was invoked. This also had a side effect that the linter could not see that it was being invoked and the image verifier could not know it shouldn't run. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend attributes that were set when
CallFuncwas set were not set early enough and it prevented buildkit from seeing therequestid.The
requestidwould only be seen by theLLBBridgeClientand it was not set yet when theController.Solvemethod was invoked.This also had a side effect that the linter could not see that it was being invoked and the image verifier could not know it shouldn't run.
Fixes moby/buildkit#5693.