-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
history: inspect json and go template format #2964
Conversation
30442f6
to
dc65c53
Compare
https://github.com/docker/buildx/compare/master...tonistiigi:buildx:history-inspect-format?expand=1 is my wip for adding format. Main difference is that there is a new struct for history inspection instead of raw HistoryRecord with other (random) values. That struct can be formatted and provides similar output to the default text (that also now comes from printing the struct). I think this is preferred. If lgty you may finish that instead. |
Yes looks good to me, I carry over your changes and keep you posted. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
It doesn't return build name and error logs which is needed for GHA summary:
I will make some changes to handle that |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
dc65c53
to
ccca7c7
Compare
@tonistiigi Updated on top of your branch. Steps counts were missing in Also missing materials and attachments. I guess we would want this in Edit: added error sources |
c7217c1
to
d25bb03
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
d25bb03
to
f15eaa1
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
f15eaa1
to
417af36
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
JSON should be usable as function as well like |
No description provided.