-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add history trace command #2904
Conversation
a197f0b
to
78f22de
Compare
78f22de
to
d8a5cf8
Compare
Added support for viewing traces using Jaeger UI.
I think the UX is pretty ok and better than manual uploads and running The old otelutil conversion code may need some updates as well. Looks like some info, like process data, could be deduplicated. I quickly looked at |
7f84270
to
3fd4ec0
Compare
https://github.com/docker/buildx/actions/runs/13173913374/job/36769042423?pr=2904#step:6:1301
I can't repro this one on a windows machine 🤔 |
3fd4ec0
to
a1f00c8
Compare
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/docker/buildx | |||
|
|||
go 1.23.0 | |||
go 1.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 1.23.0. Seems related to https://github.com/tonistiigi/jaeger-ui-rest/blob/bb2801509720cbedaac29fbefeeef9ba24e54c45/go.mod#L3
Looking at code on this repo I don't think there is any requirement for this specific patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh would need 1.22.0 actually looking at https://github.com/docker/buildx/pull/2978/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened tonistiigi/jaeger-ui-rest#1
This comment was marked as resolved.
This comment was marked as resolved.
a1f00c8
to
10499d4
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
10499d4
to
dc27815
Compare
Includes wip trace command on top of #2891
The goal was for this command to show a trace of the build directly, for example, in Jaeger UI, but it looks like there isn't a simple API that would allow uploading a trace to an existing Jaeger image (their upload feature is an ephemeral client-side-only solution).
Options would be to upload the trace spans again via controller APIs or build our own UI-only image that we could pair with a simple server that can return the trace JSON. Separating from #2891 in order to not block that PR.
The Jaeger conversion is mostly reuse of some old code. Looks like there is also a
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger
package now that probably has similar functionality.