Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure PHP with pear/pecl installers for PHP 8.0 #1088

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Configure PHP with pear/pecl installers for PHP 8.0 #1088

merged 3 commits into from
Nov 24, 2020

Conversation

q0rban
Copy link
Contributor

@q0rban q0rban commented Nov 24, 2020

Resolves #1087

It appears that pear/pecl are not removed in PHP 8.0. Indeed, even the PHP 8.0 changelog mentions needing to install xml-rpc using pecl as of 8.0:

https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.xmlrpc

This means that PHP 7.4 and 8+ can both use the --with-pear option.

@q0rban
Copy link
Contributor Author

q0rban commented Nov 24, 2020

👋 n00b here—apologies if this is documented and I missed it. How do I fix the failed job "Verify Templating / Check For Uncomitted Changes (pull_request)"?

I figured this out. 🤦‍♂️ See #1089 .

@tianon
Copy link
Member

tianon commented Nov 24, 2020

Nicely done, thank you! 👍

@tianon tianon merged commit cf3943e into docker-library:master Nov 24, 2020
@q0rban q0rban deleted the 1087-8.0-pear branch November 24, 2020 19:10
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 24, 2020
Changes:

- docker-library/php@cf3943e: Merge pull request docker-library/php#1088 from q0rban/1087-8.0-pear
- docker-library/php@470ab97: Update put-shared link/badge
- docker-library/php@03a9fae: Update templates.
- docker-library/php@0fdd2f0: Configure PHP with pear/pecl installers for PHP 8.0 docker-library/php#1087
- docker-library/php@fa26844: Remove messages about pear being removed in PHP 8+.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable pear/pecl by default for PHP 8
3 participants