This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Make sure the metrics goroutine is scheduled #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtardif
reviewed
Jul 3, 2020
metrics/metrics.go
Outdated
| // Fire and forget, we don't want to slow down the user waiting for DD | ||
| // metrics endpoint to respond. We could lose some events but that's ok. | ||
| go func() { | ||
| wasIn <- true |
There was a problem hiding this comment.
nit : I would have put this after the defer, this would theorically wait just slightly more, still without waiting for the http response. But in practice it probably does not make a difference.
gtardif
approved these changes
Jul 3, 2020
Wait for the goroutine to be scheduled before exiting. We don't wait for the metrics event to be sent, we only make sure the goroutine is called.
bf5c181 to
159b9d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Wait for the goroutine to be scheduled before exiting. We don't wait for
the metrics event to be sent, we only make sure the goroutine is called.
Inpired by this change