Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monobank request errors #11

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix monobank request errors #11

merged 1 commit into from
Feb 15, 2024

Conversation

shellshock1953
Copy link
Contributor

  • Extra slash in monobank URL causes API to reply with 403
  • more informative error for monobank failed API request

@shellshock1953
Copy link
Contributor Author

http https://api.monobank.ua//personal/statement/REDACTED/1707516000000/1707948000000 X-Token:REDACTED

HTTP/1.1 403 Forbidden
Connection: keep-alive
Content-Type: application/xml
Date: Thu, 15 Feb 2024 19:25:47 GMT
Server: AmazonS3
Transfer-Encoding: chunked

<?xml version="1.0" encoding="UTF-8"?>
<Error>
  <Code>AccessDenied</Code>
  <Message>Access Denied</Message>
</Error>

@@ -3,7 +3,7 @@
const actualApi = require('@actual-app/api');

const CACHE_DIR_PATH = '.cache/';
const MONO_URL = 'https://api.monobank.ua/';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused 403, luckily easy-fix.

@prizrak1609 prizrak1609 merged commit 15bc1ad into main Feb 15, 2024
1 check passed
@prizrak1609 prizrak1609 deleted the fix-mono-api branch February 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants