Trigger to open the support widget #1331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba3ccc1 to
f5123a0
Compare
- yarn add --dev jest @vue/test-utils @vue/vue3-jest babel-jest @babel/preset-env - Add .babelrc - Update jest.config.js - Add styleMock.js to handle CSS imports in Vue components
1d424de to
8f6c52b
Compare
dallasread
commented
Feb 7, 2025
| @@ -101,27 +114,33 @@ export default { | |||
| }, | |||
| focus () { | |||
| const $header = this.$refs.header; | |||
| nextTick(() => { | |||
There was a problem hiding this comment.
Need to wait a tick before the input is rendered.
dallasread
commented
Feb 7, 2025
| const script = document.createElement('script'); | ||
| this.isLoading = true; | ||
| script.type = 'text/javascript'; | ||
| script.src = `${this.rootURL}/search.js`; | ||
| script.src = `https://support.dnsimple.com/search.js`; |
There was a problem hiding this comment.
This'll be cleaned up when we add multiple sources (eg. dev site articles).
dallasread
commented
Feb 7, 2025
| @@ -32,8 +32,8 @@ | |||
| "scripts": { | |||
| "live": "concurrently 'bundle exec nanoc live' 'bundle exec rake compile'", | |||
| "build": "./node_modules/.bin/webpack && vite build ./_widget", | |||
| "lint": "eslint _widget content spec", | |||
| "lint:fix": "eslint _widget content spec --fix", | |||
| "lint": "eslint _widget src spec", | |||
dallasread
commented
Feb 7, 2025
templates/search.js.erb
Outdated
There was a problem hiding this comment.
Can't wait to not make this an erb file. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the support widget fill more of the screen, as well:
data-dnsimple-open-support-widget: can be added to any DOM element to trigger the opening of the widget.data-dnsimple-current-site-url="https://NOTHING.dnsimple.com": used to determine if the article is for the site the customer is already on. For example, if the customer is @ dnsimple.com and they search for alias, we want the result to show in the support widget browser. If they are on support.dnsimple.com, then we want to do a full page load to the result.QA
Test using
yarn widget:alias.data-dnsimple-current-site-url="https://NOTHING.dnsimple.com"doesn't match the current site).Test the preview:
alias.Test on DNSimple.com: