Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds yamllint and markdownlint #50

Merged
merged 4 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
---

version: 2
updates:
- package-ecosystem: "github-actions"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/check_deps.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the other PRs. Please ensure the standard templates are updated.


name: Check Dependencies

on:
Expand Down
26 changes: 25 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,38 @@
---

name: CI

on:
pull_request:
push:
branches: [ "main" ]
branches:
- main
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
yamllint:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
- name: Run YAML Lint
uses: actionshub/yamllint@main

markdownlint-cli:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
- name: Run markdownlint-cli
uses: nosborn/github-action-markdown-cli@v3.4.0
with:
files: .
config_file: ".markdownlint.yaml"

build:
name: Build
runs-on: ubuntu-latest
Expand Down Expand Up @@ -44,6 +66,8 @@ jobs:

needs:
- build
- markdownlint-cli
- yamllint

steps:
- uses: actions/checkout@v4
Expand Down
13 changes: 13 additions & 0 deletions .markdownlint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
default: true

# no-hard-tabs
MD010:
code_blocks: false

# no-multiple-blanks
MD012:
maximum: 2

# line-length
MD013: false
9 changes: 9 additions & 0 deletions .yamllint
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
extends: default
rules:
line-length:
max: 256
level: warning
truthy:
ignore: |
/.github/workflows/*.yml
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Getting started

#### 1. Clone the repository
### 1. Clone the repository

Clone the repository and move into it:

Expand All @@ -11,15 +11,15 @@ git clone git@github.com:dnsimple/dns_erlang.git
cd dns_erlang
```

#### 2. Install Erlang
### 2. Install Erlang

#### 3. Create your own working branch
### 3. Create your own working branch

```shell
git checkout -b dev_new_feature_xyz
```

#### 3. Build and test
### 3. Build and test

Compile the project and [run the test suite](#testing) to check everything works as expected.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Note that all support RR types must include a `dns_rrdata_` record definition, u

The `dns` module is the primary entry point for the functionality in this library. The module exports various types used in type specs, such as `message()`, which indicates a `#dns_message` record, `query()` which represents a single `#dns_query` record, `questions()`, which represents a list of queries, etc.

It also exports functions for encoding and decoding messages, TSIG supporting functions, and various utility functions for comparing domain names, converting domain names into different cases, converting to and from label lists, etc.
It also exports functions for encoding and decoding messages, TSIG supporting functions, and various utility functions for comparing domain names, converting domain names into different cases, converting to and from label lists, etc.

### dns\_record.erl

Expand Down