Replace xclip with xsel #3410
Merged
Replace xclip with xsel #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnschneid
requested changes
Nov 9, 2017
chroot-bin/croutonclip
Outdated
| else | ||
| echo -n "EUnable to open display '$current'." | ||
| echo -n "Unable to open display '$current'." |
There was a problem hiding this comment.
Actually, this wasn't a typo. Error messages sent to the extension are prefixed with E
| | diff -q - "$cliptmp" > /dev/null; then | ||
| cat "$cliptmp" | rundisplay "$next" xclip -i -sel clip | ||
| rundisplay "$next" xsel -ib < "$cliptmp" |
There was a problem hiding this comment.
I don't even know how a useless use of cat snuck into the codebase to begin with. Thanks for fixing that :)
|
I amended the commit and force pushed it, not sure if that breaks anything on GitHub. Thanks for the review! |
|
Yep, that's the way to do it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1812.
xclipoutputsError: target STRING not availablewhen the clipboard is empty, andxseldoes not, so it might be good to just replacexclipwithxsel, since they're functionally identical for our purposes.This may also help with bug reporting, because some people get confused by the error line, even though nothing's wrong. For example, the titles of #1765 and #1931 are misleading.