Create User invalid request has a response which returns 500 #5228

DNN Platform/Library/DotNetNuke.Library.csproj

@@ -230,6 +230,7 @@
     <Compile Include="Entities\Portals\PortalAliasExtensions.cs" />
     <Compile Include="Entities\Portals\PortalSettingUpdatedEventArgs.cs" />
     <Compile Include="Entities\Portals\PortalTemplateEventArgs.cs" />
+    <Compile Include="Entities\Users\Exceptions\InvalidPasswordException.cs" />
     <Compile Include="Entities\Users\UpdateUserEventArgs.cs" />
     <Compile Include="Entities\Content\ContentTypeMemberNameFixer.cs" />
     <Compile Include="Collections\EnumerableExtensions.cs" />

DNN Platform/Library/Entities/Users/Exceptions/InvalidPasswordException.cs

@@ -0,0 +1,28 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information
+
+namespace DotNetNuke.Entities.Users
+{
+    using System;
+
+    [Serializable]
+    public class InvalidPasswordException : Exception
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="InvalidPasswordException"/> class.
+        /// </summary>
+        public InvalidPasswordException()
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="InvalidPasswordException"/> class.
+        /// </summary>
+        /// <param name="message"></param>
+        public InvalidPasswordException(string message)
+            : base(message)
+        {
+        }
+    }
+}

Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Users/RegisterController.cs

@@ -243,7 +243,7 @@ public UserBasicDto Register(RegisterationDetails registerationDetails)
 
             if (createStatus != UserCreateStatus.Success)
             {
-                throw new Exception(UserController.GetUserCreateStatus(createStatus));
+                throw new InvalidPasswordException(UserController.GetUserCreateStatus(createStatus));
             }
 
             // if (registerationDetails.IgnoreRegistrationMode)

Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/UsersController.cs

@@ -69,9 +69,16 @@ public HttpResponseMessage CreateUser(CreateUserContract contract)
                     : null);
             }
             catch (Exception ex)
-            {
-                Logger.Error(ex);
-                return this.Request.CreateErrorResponse(HttpStatusCode.InternalServerError, ex.Message);
+            {
+                if (ex.GetType() == typeof(InvalidPasswordException))
+                {
+                    return this.Request.CreateErrorResponse(HttpStatusCode.BadRequest, ex.Message);
+                }
+                else
+                {
+                    Logger.Error(ex);
+                    return this.Request.CreateErrorResponse(HttpStatusCode.InternalServerError, ex.Message);
+                }
             }
         }