Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve server screen UI #5152

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Improve server screen UI #5152

merged 2 commits into from
Jun 22, 2022

Conversation

donker
Copy link
Contributor

@donker donker commented Jun 22, 2022 •
edited
Loading

Improves the edit boxes UI
Screenshot 2022-06-22 at 22 22 47

@donker donker added this to the 9.11.0 milestone Jun 22, 2022
@donker donker self-assigned this Jun 22, 2022
mtrutledge
mtrutledge reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@mtrutledge mtrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @donker, wouldn't we need to do the same changes on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpAdminController.cs

that you did on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpHostController.cs

since the SMTP service on the javascript end checks if the user is an admin or a host and then calls a different end point?

@donker
Copy link
Contributor Author

donker commented Jun 22, 2022

Hey @donker, wouldn't we need to do the same changes on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpAdminController.cs

that you did on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpHostController.cs

since the SMTP service on the javascript end checks if the user is an admin or a host and then calls a different end point?

Good catch. Thanks.

mtrutledge
mtrutledge approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@mtrutledge mtrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @donker

@mitchelsellers mitchelsellers merged commit 56d41a7 into dnnsoftware:develop Jun 22, 2022
@david-poindexter
Copy link
Contributor

Good job @donker - thanks for the quick contribution on this!

@donker donker deleted the smptset branch July 24, 2022 08:27
valadas added a commit to valadas/Dnn.Platform that referenced this pull request Dec 18, 2022
@valadas
Fixed an issue that prevented sending smtp test emails
90d521f 
Fixed an issue that prevented sending smtp test emails
Due to the UI changes in dnnsoftware#5152 the frontend now posts an obfuscated password unless the user is currently changing the password.
That scenario got handled correctly for UpdateSmtpSettings but the same logic needed to be implements in SendTestEmail for that button to work fine.
@valadas valadas mentioned this pull request Dec 18, 2022
Merged
bdukes pushed a commit that referenced this pull request Dec 19, 2022
@valadas @bdukes
Fixed an issue that prevented sending smtp test emails
d754acf 
Fixed an issue that prevented sending smtp test emails
Due to the UI changes in #5152 the frontend now posts an obfuscated password unless the user is currently changing the password.
That scenario got handled correctly for UpdateSmtpSettings but the same logic needed to be implements in SendTestEmail for that button to work fine.
zyhfish pushed a commit to zyhfish/Dnn.Platform that referenced this pull request Dec 29, 2022
@valadas @zyhfish
Fixed an issue that prevented sending smtp test emails
9ce5dea 
Fixed an issue that prevented sending smtp test emails
Due to the UI changes in dnnsoftware#5152 the frontend now posts an obfuscated password unless the user is currently changing the password.
That scenario got handled correctly for UpdateSmtpSettings but the same logic needed to be implements in SendTestEmail for that button to work fine.
@DimpeeTheCoder DimpeeTheCoder mentioned this pull request Jun 26, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@mtrutledge mtrutledge mtrutledge approved these changes

@david-poindexter david-poindexter Awaiting requested review from david-poindexter

Assignees

@donker donker

Labels
Area: AE > PersonaBar Ext > Servers.Web Type: Enhancement
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@donker @david-poindexter @mtrutledge @mitchelsellers