Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused Fare nuget package #4857

Closed
wants to merge 1 commit into from
Closed

Removed unused Fare nuget package #4857

wants to merge 1 commit into from

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Oct 4, 2021

Supercedes #4855

Summary

@valadas valadas added this to the 9.10.2 milestone Oct 4, 2021
@valadas
Copy link
Contributor Author

valadas commented Oct 4, 2021

Let's see if all tests pass, but I think this reference was simply unused...

@bdukes
Copy link
Contributor

bdukes commented Oct 5, 2021

TestStack.Dossier depends on AutoFixture which depends on Fare. It's only used in the integration tests project, so we wouldn't get a test failure from the CI build.

Dnn.Platform/DNN Platform/Tests/DotNetNuke.Tests.Integration/Executers/Builders/TabPermissionsBuilder.cs

Lines 10 to 12 in 857cf0d

using TestStack.Dossier;
public class TabPermissionsBuilder : TestDataBuilder<TabPermissions, TabPermissionsBuilder>

@valadas
Copy link
Contributor Author

valadas commented Oct 5, 2021

Oh I see, ok, let's close this then

@valadas valadas closed this Oct 5, 2021
@valadas valadas deleted the remove-fare branch April 14, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@valadas @bdukes