Clean up warnings in DnnExportImport #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Dec 16, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
valadas
requested changes
Dec 16, 2020
DNN Platform/Modules/DnnExportImport/Components/Controllers/BaseController.cs
Outdated
Show resolved
Hide resolved
| file.EndDate ?? Null.NullDate, | ||
| file.EnablePublishPeriod, | ||
| Null.NullInteger); | ||
| ////file.ContentItemId ?? Null.NullInteger);--If we keep it we will see FK_PK relationship errors. |
There was a problem hiding this comment.
Should we just delete this line ?
| localTab.IsVisible = otherTab.IsVisible; | ||
| EntitiesController.Instance.SetTabSpecificData(localTab.TabID, false, localTab.IsVisible); | ||
|
|
||
| // tabController.UpdateTab(localTab); // to clear cache |
There was a problem hiding this comment.
Should we remove commented out code ?
There was a problem hiding this comment.
We can, doesn't matter much to me either way. For both of them you've called out here, there's at least a comment indicating the thinking somewhat, which might protect against re-making the same mistake.
594 obsolete and documentation warnings remain Co-authored-by: Daniel Valadas <info@danielvaladas.com>
9512135 to
2b5853c
Compare
donker
approved these changes
Dec 21, 2020
valadas
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
594 obsolete and documentation warnings remain