Feature/add google tagmanager connector #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
requested changes
Oct 28, 2020
DNN Platform/Connectors/GoogleTagManager/Dnn.GoogleTagManagerConnector.sln
Outdated
Show resolved
Hide resolved
Thanks. I corrected my mistakes as you suggested. |
|
This is also related to #3155 and if this PR is accepted, we should close that issue as well. Awesome @skamphuis - I will review the PR as soon as possible. |
david-poindexter
requested changes
Oct 28, 2020
DNN Platform/Connectors/GoogleTagManager/GoogleTagManager.config
Outdated
Show resolved
Hide resolved
valadas
approved these changes
Oct 31, 2020
david-poindexter
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
Awesomeness - I am excited about this one - thanks @skamphuis 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4254
Summary
I created this Google Tag Manager connector by simply taking a copy of the Google Analytics Connector project and changing it to fit the needs of Google Tag Manager.
I had to add the Controller class and the Engine class to the project. These are located in the DNN core for Google Analytics. (But I didn't want to change the core)
SiteAnalytics.config will need to be edited too, with the part from the .config file in this PR.