enable "unauthenticated users" role in the list. #4095
Conversation
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/Services/ComponentsController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/Services/ComponentsController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/Services/ComponentsController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/Services/ComponentsController.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I agree with all of the feedback provided by @bdukes and additionally want to call to attention a testing concern here.
Looking back historically it seems that this has been an issue since the inception of the PersonaBar. The current workaround to add/remove those users is to use a combination of "All Users" and "Registered Users" with approve/deny.
Have we tested the downstream processes, after setting these values in this manner that all security at the page level is still working as intended?
|
I know, it is a big change, but ideally, We should replace "Unauthenticated Users, "unverified Users" and "registered Users roles together with "autoorized" and "deleted" by asaingle workflow state. |
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/Services/ComponentsController.cs
Outdated
Show resolved
Hide resolved
| @@ -33,6 +36,8 @@ public class ComponentsController : PersonaBarApiController | |||
|
|
|||
| public string LocalResourcesFile => Path.Combine("~/DesktopModules/admin/Dnn.PersonaBar/App_LocalResources/SharedResources.resx"); | |||
|
|
|||
| private int UnauthUserRoleId => int.Parse(Globals.glbRoleUnauthUser, CultureInfo.InvariantCulture); | |||
There was a problem hiding this comment.
| private int UnauthUserRoleId => int.Parse(Globals.glbRoleUnauthUser, CultureInfo.InvariantCulture); | |
| private static readonly int UnauthUserRoleId => int.Parse(Globals.glbRoleUnauthUser, CultureInfo.InvariantCulture); |
…ntsController.cs explciit -1 Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Fix #4094