Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pencil icon aligned for unpublished pages #3961

Closed

Conversation

tauqeer-haider
Copy link
Contributor

Fixes #3960

Summary

The pencil icon was misaligned due to a recent change that had introduced ellipsis for longer page names. The pencil icon will now show after a fixed text length which is required for ellipsis to work.
image

@valadas
Copy link
Contributor

valadas commented Aug 5, 2020

I never saw that icon, is this Evoq specific ?

@mitchelsellers
Copy link
Contributor

This is an Evoq item based on workflows

@tauqeer-haider
Copy link
Contributor Author

I never saw that icon, is this Evoq specific ?

Yes, I believe.

@valadas
Copy link
Contributor

valadas commented Aug 6, 2020

I know this changed in a previous PR relating to the page names being cut too short. I don't have time to test this right now but i would like to have some testing, can we still see the whole page name somehow (tooltip or left-right scroll or some such) ?

@EPTamminga
Copy link
Contributor

EPTamminga commented Aug 6, 2020

I can see the full name as tooltip

image

@bdukes bdukes added this to the 9.7.1 milestone Aug 7, 2020
@valadas
Copy link
Contributor

valadas commented Aug 11, 2020

In my very own opinion, I would prefer the icons moved into the ... menu and keeping more room for the page title. It is already a very tight UI and with nested pages, every pixel we can gain for room for the title is welcome as it quickly becomes almost unusable with a couple of nested levels...

@tauqeer-haider
Copy link
Contributor Author

In my very own opinion, I would prefer the icons moved into the ... menu and keeping more room for the page title. It is already a very tight UI and with nested pages, every pixel we can gain for room for the title is welcome as it quickly becomes almost unusable with a couple of nested levels...

Sure I will check.

@mitchelsellers
Copy link
Contributor

It is my belief that this should actually be closed, as the Evoq installations utilize a DIFFERENT pages module so changes here might not directly translate to their installation. We will add this as a topic of discussion today in the Technology meeting

@valadas or @david-poindexter thoughts?

@mitchelsellers
Copy link
Contributor

Reviewed in the Technology approvers meeting today, this change is for an Evoq feature, not a feature of DNN Platform. This change could be made by Evoq in their pages module.

@tauqeer-haider tauqeer-haider deleted the bugfix/DNN-40834 branch August 27, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pencil icon is not shown for non-published pages
5 participants