Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nl nl text installwizard & upgradewizard improvements #3869

Merged
merged 1 commit into from
Jun 28, 2020
Merged

nl nl text installwizard & upgradewizard improvements #3869

merged 1 commit into from
Jun 28, 2020

Conversation

EPTamminga
Copy link
Contributor

Close #3868

Summary

Just text corrections in nl-NL.resx files

@EPTamminga
Copy link
Contributor Author

It captured too many changed files in my PR, mu local PR creation mentioned only my 2 changed nl-NL .resx files. I created my PR from the develop branches...

@david-poindexter david-poindexter changed the base branch from develop to release/9.6.2 June 28, 2020 15:44
@david-poindexter
Copy link
Contributor

It captured too many changed files in my PR, mu local PR creation mentioned only my 2 changed nl-NL .resx files. I created my PR from the develop branches...

@EPTamminga I rebased this against the release/9.6.2 branch and it seems to now include only the intended files. Thanks - I will review now.

@david-poindexter david-poindexter added this to the 9.6.2 milestone Jun 28, 2020
david-poindexter
david-poindexter approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks @EPTamminga

valadas
valadas approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak the language but also don't see any issue with those changes, merging...

@valadas valadas changed the title Issue 3868 nl nl text installwizard & upgradewizard improvements for DNN962 nl nl text installwizard & upgradewizard improvements Jun 28, 2020
@valadas valadas merged commit 3714ff6 into dnnsoftware:release/9.6.2 Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.6.2
Development

Successfully merging this pull request may close these issues.

nl-NL textual corrections in the installwizard
3 participants
@EPTamminga @david-poindexter @valadas