Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the url with case insensitive. #3202

Closed
wants to merge 1 commit into from

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Oct 25, 2019

Fix #3201

@david-poindexter
Copy link
Contributor

Hi @zyhfish - can you remove the Jira number reference from the PR title? It can be referenced in the description if necessary but we need to keep PR titles clean moving forward. Also, this PR Is targeting development instead of release/9.4.x. Which release is intended for this change? Thanks.

@zyhfish zyhfish changed the title DNN-34236: check the url with case insensitive. check the url with case insensitive. Oct 25, 2019
@david-poindexter
Copy link
Contributor

@zyhfish is this intended for inclusion in DNN 9.4x or 10?

Currently the PR is targeting the development branch (which is for DNN 10). If you want this considered for DNN 9.4.x, please target the release/9.4.x branch. Thanks!

@zyhfish
Copy link
Contributor Author

zyhfish commented Oct 25, 2019

thanks @david-poindexter , I will create another PR later.

@david-poindexter
Copy link
Contributor

Thank @zyhfish - sorry for the hassle. The branching at this time is a bit confusing.
😁👍🏼

@zyhfish
Copy link
Contributor Author

zyhfish commented Oct 28, 2019

#3208 created.

@zyhfish zyhfish closed this Oct 28, 2019
@zyhfish zyhfish deleted the bug/DNN-34236 branch October 28, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module settings dialog can't be open if urls converted to lower case
2 participants