Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes errors with previous build scripts following PB merge #3167

Merged
merged 2 commits into from
Oct 19, 2019

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Oct 18, 2019

Closes #3166

Summary

This fixes some missing commits from the merge of the persona bar into this repository and restores ability to build a working site.

For people reviewing this, please try the following before approving.

  1. git clone -b fix-merge-build https://github.com/valadas/Dnn.Platform
  2. open powershell as admin and run ./Build.ps1
    Let it build then verify the following

** Status should be clean **
git status should show nothing to commit (providing there was no build errors that stopped the build midway in which case, you should run git reset --hard and try again fixing what caused the error.

** You should have 4 zips in the Artifacts folder **
Try a clean install.
Try an upgrade.
Verify the Persona Bar works and gets 9.4.2 version
Verify the Edit Bar works

@valadas
Copy link
Contributor Author

valadas commented Oct 18, 2019

Also note that this is not a replacement for #3137 but just fixes the current build scripts while we still work on the other one (might fix #3137 too maybe)

@valadas valadas added the DevOps label Oct 18, 2019
@valadas valadas added this to the 9.4.2 milestone Oct 18, 2019
@SkyeHoefling
Copy link
Contributor

This is going to be needed for #3160 as we don't have an installer being generated correctly by the build.

@valadas
Copy link
Contributor Author

valadas commented Oct 18, 2019

@ahoefling can you give it a test please.

@SkyeHoefling
Copy link
Contributor

I have tested the CreateInstall workflow which is what I noticed was broken when @valadas and I spoke offline about this issue.

  • The Install Artifact from Azure DevOps works and installs correctly
  • I cloned the PR and was able to generate an installer using ./Build.ps1 -Target CreateInstall. Generated installer worked, however I ran into file path length which was easy enough to re-clone at the root level

If interested I have attached my build log from building local
build-output.log

@mitchelsellers
Copy link
Contributor

Given that this is build related I’m exercising special approval steps to merge now.

@mitchelsellers mitchelsellers merged commit 0d20aac into dnnsoftware:release/9.4.x Oct 19, 2019
@valadas valadas deleted the fix-merge-build branch December 31, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants