Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies local build command #3092

Merged
merged 5 commits into from
Oct 5, 2019

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Oct 4, 2019

This simply makes the previous --BuildAll target the default so it allows even simpler local builds, users can now just type the file name without parameters:

./build.ps1 vs ./build.ps1 --Target BuildAll

And it updates the documentation for building as per this change and the merging of AdminExperience.

mitchelsellers
mitchelsellers previously approved these changes Oct 4, 2019
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

.github/BUILD.md Outdated Show resolved Hide resolved
.github/BUILD.md Outdated Show resolved Hide resolved
bdukes
bdukes previously approved these changes Oct 4, 2019
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a couple of typo fixes

Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>
@valadas valadas dismissed stale reviews from bdukes and mitchelsellers via a3db9cd October 5, 2019 06:36
Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>
@valadas
Copy link
Contributor Author

valadas commented Oct 5, 2019

Thanks for spotting that, changes accepted. Please re-review @bdukes and @mitchelsellers

@donker donker merged commit 3d984cc into dnnsoftware:release/9.4.x Oct 5, 2019
@valadas valadas added this to the 9.4.2 milestone Nov 4, 2019
@valadas valadas added the chore label Nov 4, 2019
@valadas valadas deleted the default-buildall branch December 31, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants