Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Append disabled flag #2623

Merged
merged 3 commits into from
Apr 9, 2019
Merged

- Append disabled flag #2623

merged 3 commits into from
Apr 9, 2019

Conversation

Mhtshum
Copy link
Contributor

@Mhtshum Mhtshum commented Mar 11, 2019 •
edited
Loading

Fixes #2594

Summary

  • Append , includeDisabled in call from UI

@Mhtshum Mhtshum mentioned this pull request Mar 11, 2019
Closed
bdukes
bdukes approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daguiler daguiler added this to the 9.3.1 milestone Mar 13, 2019
daguiler
daguiler suggested changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@daguiler daguiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this as a component parameter, because this is a shared component. I think the param should be 'false' by default so that disabled pages are not shown, and 'true' only for this particular case.
Thoughts?

daguiler
daguiler approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@daguiler daguiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@mitchelsellers mitchelsellers merged commit 11a19a4 into dnnsoftware:development Apr 9, 2019
mitchelsellers added a commit that referenced this pull request Apr 9, 2019
@mitchelsellers
Revert "- Append disabled flag (#2623)"
cbba2d8 
This reverts commit 11a19a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daguiler daguiler daguiler approved these changes

@bdukes bdukes bdukes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Mhtshum @bdukes @daguiler @mitchelsellers