Skip to content

Commit

Permalink
Resolves 101 build warnings on CoreMessaging project (#4216)
Browse files Browse the repository at this point in the history
* Resolves 101 build warnings on CoreMessaging project

- Resolves 101 warnings
- Prevents sending detailed errors to frontend
- Updates documentation and settings here and there to make it build and correct related documentation
- Enabled TreatBuildWarningsAsErrors on project

* Resolves a build failure due to deprecated PortalID in PortalInfo

* Update DNN Platform/Library/Services/Exceptions/Exceptions.cs

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
  • Loading branch information
valadas and bdukes authored Oct 22, 2020
1 parent 34a5a55 commit 70d2db1
Show file tree
Hide file tree
Showing 17 changed files with 1,804 additions and 1,494 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<DocumentationFile>bin\Dnn.Modules.Console.XML</DocumentationFile>
<NoWarn>1591</NoWarn>
<NoWarn>
</NoWarn>
<LangVersion>7</LangVersion>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
Expand All @@ -43,8 +44,10 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<DocumentationFile>bin\Dnn.Modules.Console.XML</DocumentationFile>
<NoWarn>1591,1573</NoWarn>
<NoWarn>
</NoWarn>
<LangVersion>7</LangVersion>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<ItemGroup>
<Reference Include="DotNetNuke.WebUtility, Version=4.2.1.783, Culture=neutral, PublicKeyToken=null">
Expand Down
Loading

0 comments on commit 70d2db1

Please sign in to comment.