Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Conversation

kkadir
Copy link

@kkadir kkadir commented Aug 14, 2019

Fixes #1112

Summary

Introduce;

  • addPagesComplete action,
  • FORCE_PAGE_LIST_LOAD and UNFORCE_PAGE_LIST_LOAD action types,
  • New cases in reducer regarding the new action types,
  • multiplePagesAdded state
    To enable tracking the multiple pages adding flow.

Finally, assure that child lists for all items in the pages list are loaded by updating the logic slightly in the toggleExpandAll() function.

Confirmation Video

@kkadir
Copy link
Author

kkadir commented Aug 17, 2019

Hello @valadas, @bdukes, did you have a chance to review this PR?

@valadas
Copy link
Contributor

valadas commented Aug 19, 2019

It looks ok from a quick look but I did not test it yet properly..

@kkadir
Copy link
Author

kkadir commented Aug 22, 2019

Hello @valadas, @bdukes; it would be nice if you can review this PR, just a friendly reminder :)

@mitchelsellers
Copy link
Contributor

This request is targeting the "Development" branch, which is for consideration for the 10.0 release, we will be resuming review of these items after the 9.4.0 release is done

@valadas valadas added this to the 10.0.0 milestone Sep 10, 2019
@mikebigun
Copy link
Contributor

Dear community, let me know please if you have any concerns to have this merged. Thanks.

@mitchelsellers
Copy link
Contributor

@mikebigun this is targeting development and is on hold for merging

@mikebigun
Copy link
Contributor

There is a much simpler solution available here: #1175
This PR can be closed if new fix satisfies community.

@daguiler
Copy link
Contributor

Closing in favor of #1175

@daguiler daguiler closed this Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persona Bar > Manage > Pages > Expand All Fails After Adding Multiple Pages
6 participants