Multiline string grammar #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.12.10
Release 0.12.11
Release 0.13.0
Release 0.13.1
Release 0.14.0
* add snapshot workflow * add snapshot workflow * set version to snapshot, add developer docs * add test * fix release notes * add code generation example * add test * APPS-573 escape strings when generating/formatting code unless they are in the command block (dnanexus#134) Merge adjacent ExprStrings to make escaping easier, and call escape on strings in the code formatter and generator, as long as they are not in the command section. * fix snapshot workflow * improve build.sbt * fix repository name * add test * add comment * Do not treat placeholder options as occurring 'inPlaceholder' when generating code (dnanexus#135) Expressions in placeholders are handled a bit differently, but this should only apply to the expression itself, not any expressions used in placeholder options. * merge developer docs, add instructions to run make * APPS-581 always unwrap optional (dnanexus#137) The issue in APPS-581 is that the evaluation of an "at" expression (e.g. array[0]) is expecting a non-optional value. V_Optional doesn't actually appear to be used for anything anymore - we should consider it for removal but I don't want to do so until we have more extensive tests. A short term fix is to automatically unwrap all evaluation results. * APPS-579 Add regression tests for expression evaluation: boolean, substitution. (dnanexus#136) * update to dxCommon 0.3.0 * update release notes * fix quoting of placeholder options (dnanexus#139) The previous fix for placeholders was not quite correct - it failed to put quotes around literal values. It also assumed you can't have nested placeholders, which is incorrect. This fixes both issues. * update versions and changelogs * use WdlOptions for parsing (dnanexus#143) dd Any-type array argument type as valid for concatenation function * Exclude `loc` field from `equals` and `hashCode` in AST case classes (dnanexus#144) Moves loc to the second parameter section in AST case classes. Renames some AST field names for greater clarity. Cleans up parser code and improves error messages. Bumps version. * Don't strip indent from command block in code formatter/generator (dnanexus#145) Previously the code formatter/generator tried to be clever and reformat the code block to use indenting consistent with the rest of the WDL file, but this can break some complex bash scripts. This PR removes that logic and just leaves the command block as-is. * Store quoting type in AST (dnanexus#146) * Store quote type in AST * Allows any type of expression to be used as the value of the default placeholder option * No longer performs parameter_meta validation at parse time - it is already done at type-check time * APPS-589 State machine for formatting expressions (dnanexus#147) Implements a simple state machine for formatting WDL expressions, in order to better handle nested quotes and placeholders. * merge changelog, bump version * Fix quoting and escaping of import URIs by code generator/formatter (dnanexus#150) Fix quoting and escaping of import URIs by code generator/formatter * add test * Disable line wrapping in placeholders (dnanexus#151) disables line wrapping in placeholders. * update changelog and version * Add tool to automatically fix some non-standard WDL sytanx (dnanexus#149) Adds tool to automatically fix some non-standard WDL syntax. Improves Eval error messages. * update version and changelog * Fix some issues with the `fix` command (dnanexus#154) * fix output paths for imports that are relative to a common ancestor; move document writing to separate function shared by Fix, Format, and Upgrade * allow auto-coercion of read_* return values * handle case where there's only one file * update docs * update makefile * support coercion from optional type to string within placeholder (dnanexus#156) * update docs * fix snapshot query * update changelog and version * update dxCommon version * add test * update changelog, add test * add aliases for v1.1 * Support `container` as alias for `docker` in WDL 1.1 (dnanexus#158) * add aliases for v1.1 * support 'container' as an alias for 'docker' in WDL 1.1 * Update Runtime.scala * Add corpora of public WDLs for testing (dnanexus#159) * Allow primitive -> String coercion for WDL versions <= 1.0 * Fixes the grammar for expressions, because the order of operations was not being respected for unary operations * A parameter_meta key that does not correspond to an input or output parameter is now ignored with a warning unless parsing in strict mode * Previously, imports were cached using their relative path, which could lead to unexpected results if two imports have the same relative path. Now absolute paths are used. * Fixes case where the fix tool would generate an invalid declaration * update dxCommon to published version * update changelog and version * update dependency version Co-authored-by: Riva Nathans <rnathans-cf@dnanexus.com>
* add snapshot workflow * add snapshot workflow * set version to snapshot, add developer docs * add test * fix release notes * add code generation example * add test * APPS-573 escape strings when generating/formatting code unless they are in the command block (dnanexus#134) Merge adjacent ExprStrings to make escaping easier, and call escape on strings in the code formatter and generator, as long as they are not in the command section. * fix snapshot workflow * improve build.sbt * fix repository name * add test * add comment * Do not treat placeholder options as occurring 'inPlaceholder' when generating code (dnanexus#135) Expressions in placeholders are handled a bit differently, but this should only apply to the expression itself, not any expressions used in placeholder options. * merge developer docs, add instructions to run make * APPS-581 always unwrap optional (dnanexus#137) The issue in APPS-581 is that the evaluation of an "at" expression (e.g. array[0]) is expecting a non-optional value. V_Optional doesn't actually appear to be used for anything anymore - we should consider it for removal but I don't want to do so until we have more extensive tests. A short term fix is to automatically unwrap all evaluation results. * APPS-579 Add regression tests for expression evaluation: boolean, substitution. (dnanexus#136) * update to dxCommon 0.3.0 * update release notes * fix quoting of placeholder options (dnanexus#139) The previous fix for placeholders was not quite correct - it failed to put quotes around literal values. It also assumed you can't have nested placeholders, which is incorrect. This fixes both issues. * update versions and changelogs * use WdlOptions for parsing (dnanexus#143) dd Any-type array argument type as valid for concatenation function * Exclude `loc` field from `equals` and `hashCode` in AST case classes (dnanexus#144) Moves loc to the second parameter section in AST case classes. Renames some AST field names for greater clarity. Cleans up parser code and improves error messages. Bumps version. * Don't strip indent from command block in code formatter/generator (dnanexus#145) Previously the code formatter/generator tried to be clever and reformat the code block to use indenting consistent with the rest of the WDL file, but this can break some complex bash scripts. This PR removes that logic and just leaves the command block as-is. * Store quoting type in AST (dnanexus#146) * Store quote type in AST * Allows any type of expression to be used as the value of the default placeholder option * No longer performs parameter_meta validation at parse time - it is already done at type-check time * APPS-589 State machine for formatting expressions (dnanexus#147) Implements a simple state machine for formatting WDL expressions, in order to better handle nested quotes and placeholders. * merge changelog, bump version * Fix quoting and escaping of import URIs by code generator/formatter (dnanexus#150) Fix quoting and escaping of import URIs by code generator/formatter * add test * Disable line wrapping in placeholders (dnanexus#151) disables line wrapping in placeholders. * update changelog and version * Add tool to automatically fix some non-standard WDL sytanx (dnanexus#149) Adds tool to automatically fix some non-standard WDL syntax. Improves Eval error messages. * update version and changelog * Fix some issues with the `fix` command (dnanexus#154) * fix output paths for imports that are relative to a common ancestor; move document writing to separate function shared by Fix, Format, and Upgrade * allow auto-coercion of read_* return values * handle case where there's only one file * update docs * update makefile * support coercion from optional type to string within placeholder (dnanexus#156) * update docs * fix snapshot query * update changelog and version * update dxCommon version * add test * update changelog, add test * add aliases for v1.1 * Support `container` as alias for `docker` in WDL 1.1 (dnanexus#158) * add aliases for v1.1 * support 'container' as an alias for 'docker' in WDL 1.1 * Update Runtime.scala * Add corpora of public WDLs for testing (dnanexus#159) * Allow primitive -> String coercion for WDL versions <= 1.0 * Fixes the grammar for expressions, because the order of operations was not being respected for unary operations * A parameter_meta key that does not correspond to an input or output parameter is now ignored with a warning unless parsing in strict mode * Previously, imports were cached using their relative path, which could lead to unexpected results if two imports have the same relative path. Now absolute paths are used. * Fixes case where the fix tool would generate an invalid declaration * update dxCommon to published version * update version and release notes * Handle T_Any in placeholders (dnanexus#162) * handle empty sections in code generator/formatter (dnanexus#161) * update release workflow * update version and release notes * Don't unwrap optional for OverridableInputParameterWithDefault (dnanexus#164) * don't unwrap optional for OverridableInputParameterWithDefault * udpate corpora tests * automatially fix an assignment of map literal to struct variable - convert it to object literal * Auto fix map literal (dnanexus#165) automatially fix an assignment of map literal to struct variable - convert it to object literal * unquote version id * Update README.md * add Runtime.returnCodes accessor (dnanexus#167) * fix formatting of single-line expressions in code generator/formatter (dnanexus#168) * always allow coercion to T_Any (dnanexus#171) * fix default memory value for development (dnanexus#170) * update release workflow * update version and changelog * update dependencies * update dxCommon version * add parameters for runtime and hint overrides to `Eval.Runtime` and `Eval.Meta` classes; (dnanexus#173) * update developer notes * Increment develop version. (dnanexus#174) * Set version 0.16.0. * Increment develop version. * Add self to developers. * Return codes2 (dnanexus#176) * fix ordering of types for returnCodes * update changelog * update changelog * evaluate expressions in order (dnanexus#177) * wdlTools 0.17.0. * Fix release notes. Co-authored-by: jdidion <github@didion.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-line strings have been approved for the
developmentversion of WDL: openwdl/wdl#414. In addition, support forcommand {}style command blocks and${}style placeholders has been removed.This PR adds the necessary changes to the ANTLR4 grammar.