Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"minimum max" filter bug #107

Closed
Bernadetadad opened this issue Feb 21, 2024 · 4 comments · Fixed by #170
Closed

"minimum max" filter bug #107

Bernadetadad opened this issue Feb 21, 2024 · 4 comments · Fixed by #170

Comments

@Bernadetadad
Copy link

Bernadetadad commented Feb 21, 2024 •
edited
Loading

@jbloom currently if I adjust "minimum max of escape at site' it does not filter out sites that are in the library but have been removed by other filters (dark grey squares, see attached). I believe this is a bug as it previously was filtering just for the minimum max sites and removing everything else. line plot seems to work as expected.

image
@Bernadetadad
Copy link
Author

@jbloom could you fix this when you have time, it's hard to look at mAb escape heat maps with this bug in place

@jbloom
Copy link
Contributor

jbloom commented Mar 5, 2024

I have looked at it but have not figured out how to fix it yet! I will look more as soon as I have time.

@jbloom
Copy link
Contributor

jbloom commented Mar 5, 2024

If you need a short-term workaround for a paper figure, let me know.

@jbloom
Copy link
Contributor

jbloom commented Dec 15, 2024

This is only a problem with the antibody escape plots, not the ones with functional effects. Maybe the issue is in polyclonal?

jbloom added a commit to jbloomlab/polyclonal that referenced this issue Dec 16, 2024
@jbloom
Fix bug in plotting `minimum max of <stat> at site slider
2d68e61 
Fix bug in `plot.lineplot_and_heatmap` where the `minimum max of <stat> at site`
failed to keep only the top sites when hide not filter option was being used.

Addresses [this issues](dms-vep/dms-vep-pipeline-3#107).
@jbloom jbloom mentioned this issue Dec 16, 2024
Merged
jbloom added a commit to jbloomlab/polyclonal that referenced this issue Dec 16, 2024
@jbloom
Fix bug in plotting `minimum max of <stat> at site slider (#187)
684e28e 
Fix bug in `plot.lineplot_and_heatmap` where the `minimum max of <stat> at site`
failed to keep only the top sites when hide not filter option was being used.

Addresses [this issues](dms-vep/dms-vep-pipeline-3#107).
@jbloom jbloom mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade polyclonal to 6.14 to fix min max of site slider dms-vep/dms-vep-pipeline-3
2 participants
@jbloom @Bernadetadad