Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim only one line at start and end #30

Closed

Conversation

dword-design
Copy link

@dword-design dword-design commented Jan 1, 2020

This PR fixes start and end trimming by only trimming one newline each. This enables us to create real newlines instead of explicit newlines (those are removed), so the strings are much cleaner.

Closes #41

@dword-design
Copy link
Author

@dmnd Any chance to get this merged?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes start and end trimming by only trimming one newline each

@dword-design is there a reason why you'd want this? Dedenting a string doesn't necessarily need to include trimming newlines from the start and/or end. Some users might not want that.

I wonder if this should be an opt-in option? Or just not in the purview of dedent specifically?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I mainly added this for trailing newlines in strings written to a file. I'd say probably don't need it anymore but I still think that the user has more possibilities. So he could add more newlines to the start or end but doesn't need to.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok interesting - similar to #29 I think it'd be good to talk in an issue first. I'll close this PR to keep the queue small, but not saying no! Just hoping to discuss :)

Thanks!

Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requested changes for housekeeping purposes - let's discuss whether this should happen first?

(not saying 'no' - just starting a thread!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants