Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cub submodule again (fixes GPU build) #2599

Merged
merged 1 commit into from
Aug 13, 2017

Conversation

RAMitchell
Copy link
Member

@RAMitchell RAMitchell commented Aug 13, 2017

Add fix from NVlabs/cub#100

@codecov-io
Copy link

codecov-io commented Aug 13, 2017

Codecov Report

Merging #2599 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
+ Coverage   35.11%   35.14%   +0.02%     
==========================================
  Files          79       79              
  Lines        6972     6972              
  Branches      680      680              
==========================================
+ Hits         2448     2450       +2     
  Misses       4424     4424              
+ Partials      100       98       -2
Impacted Files Coverage Δ
src/objective/regression_obj.cc 86.33% <0%> (-1.1%) ⬇️
src/metric/rank_metric.cc 91.35% <0%> (+0.54%) ⬆️
src/data/simple_dmatrix.cc 57.33% <0%> (+0.66%) ⬆️
src/data/sparse_page_dmatrix.cc 87.97% <0%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2d0d0...18721ea. Read the comment docs.

@RAMitchell RAMitchell merged commit 71e5e62 into dmlc:master Aug 13, 2017
@RAMitchell RAMitchell deleted the cub-fix branch December 6, 2018 19:30
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants