Fixes for multiple and default metric #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khotilov
added a commit
to khotilov/xgboost
that referenced
this pull request
Jun 5, 2016
tlorieul
pushed a commit
to tlorieul/xgboost
that referenced
this pull request
Jun 8, 2016
* fix multiple evaluation metrics * create DefaultEvalMetric only when really necessary * py test for dmlc#1239 * make travis happy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR #1153 had essentially disabled the multiple eval metrics functionality by allowing only the last metric. This one should fix it by providing a special duplication detection for
eval_metric.Also, when setting the DefaultEvalMetric right after loading, it can sometimes create unwanted default metric. So I've moved the lazy DefaultEvalMetric creation into EvalOneIter where it is invoked when really necessary.