Fix Webcam checkbox flicker & Use Checkbox::clicked signal #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signal CheckBox::toggled is also triggered when using setChecked, which is not what we want. Signal CheckBox::clicked is tiggered on user interactions only (click, touch, press space..) https://doc.qt.io/qt-6/qabstractbutton.html#toggled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is about the webcam checkbox. It flickers between ON and OFF when I click it.
This is because
MainWindow::updateData()is called after the click, but before ecData is updated.So the update contains the previous value.
Fixed by calling
updateEcData, like inMainWindow::setCoolerBoostStateThe second commit is about replacing Checkbox::toggled by Checkbox::clicked.