Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Due and Time data not set recurrence values. Fixes #858 #859

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

dmfs
Copy link
Owner

@dmfs dmfs commented Sep 27, 2019

DueData and TimeData should not set recurrence values. That's not allowed on the instances table and, apparently, it's very unexpected and error prone.

`DueData` and `TimeData` should not set recurrence values. That's not allowed on the instances table and, apparently, it's very unexpected and error prone.
Copy link

@zone-id zone-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dmfs dmfs changed the base branch from master to beta September 27, 2019 21:12
@dmfs dmfs merged commit 230e212 into beta Sep 27, 2019
@dmfs dmfs deleted the fixes/858-fix-notification-actions branch September 27, 2019 21:20
dmfs added a commit that referenced this pull request Oct 9, 2019
`DueData` and `TimeData` should not set recurrence values. That's not allowed on the instances table and, apparently, it's very unexpected and error prone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants