fix adaptive icon being too small #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I was always wondering why that happened. Thanks for fixing this. I still need to test this on a pre 7.1 device before merging though. |
|
Just realized I still have a Nexus 7 tablet with Android 5.1.1 First image is the icon after installing the app from the store (google photos app shows as size reference), the second image is after the update. Seems the older version of Android use the .png files that are in the repo, instead of the adaptive .xml file (the green blob is an edit I made to make sure I was seeing the updated image).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the adaptive icon being too small by using 108dp instead of the old 24dp, as per this official Android guide: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive
Note: according to the guide 108dp is the default for Android >7.1. I do not have access to any devices with version <=7.1 so did not test on those.
Should close #827