Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #798

Merged
merged 6 commits into from
Jun 4, 2019
Merged

Bump deps #798

merged 6 commits into from
Jun 4, 2019

Conversation

Unpublished
Copy link
Contributor

Part of #797

Running this since a few weeks without problems.

@Unpublished
Copy link
Contributor Author

Okay I fixed the lint error caused by mixed support libs by migrating to AndroidX (which should be done anyway).

Will run this over the next few days, probably upgrade them further to their latest release (1.0.2) and report back.

@dmfs
Copy link
Owner

dmfs commented May 27, 2019

Thanks a lot. I'll check it out and give it a try.

@Unpublished
Copy link
Contributor Author

Great! PR should now be in its final state.

androidx.annotation 1.0.2 is not relevant for opentasks and test_runner strictly depends on 1.0.0, so it cannot be upgraded yet.

Copy link
Owner

@dmfs dmfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found so far. Good Job!

@dmfs dmfs merged commit e0c2547 into dmfs:master Jun 4, 2019
@Unpublished
Copy link
Contributor Author

Thanks for merging!

Was about to report the same, I didn't run into issues with this branch as well.

@Unpublished Unpublished deleted the bumpDeps branch June 4, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants