Allow URIs in place of the URI field. #411 #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfs
reviewed
Dec 13, 2017
| @@ -52,7 +52,7 @@ | |||
| <!-- Task editor --> | |||
| <string name="activity_edit_task_title">Bearbeiten</string> | |||
| <string name="activity_add_task_title">Erstellen</string> | |||
| <string name="activity_edit_task_error_invalid_url">Ungültige URL</string> | |||
| <string name="activity_edit_task_error_invalid_uri">Ungültige URI</string> | |||
There was a problem hiding this comment.
I don't think we should change the translations. The term "URL" probably makes more sense than "URI" to most users.
There was a problem hiding this comment.
Ok, I've reverted those changes, and squashed-rebased so that there is only one commit with the reduced changeset. Ready for check.
bd7f7d8 to
88f4e6b
Compare
dmfs
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.