Refactor entity processor chain. Implements #533 #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8637f17 to
e63a8ad
Compare
lemonboston
approved these changes
Dec 6, 2017
| @Override | ||
| public T insert(SQLiteDatabase db, T entityAdapter, boolean isSyncAdapter) | ||
| { | ||
| Log.d("Logging EntityProcessor", "before insert"); |
There was a problem hiding this comment.
Move the tag to a constant?
This is the first step of a major refactoring of the provider. This step essentially merges the "before*" and "after*" methods of `EntityProcessor` and converts most implementations into decorators.
e63a8ad to
f1d408e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of a major refactoring of the provider. This step essentially merges the "before*" and "after*" methods of
EntityProcessorand converts most implementations into decorators.