Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenTasksPal to use latest ContentPal with Projection, View ch… #518

Merged
merged 2 commits into from
Nov 29, 2017

Conversation

lemonboston
Copy link
Contributor

…anges. #517

@lemonboston
Copy link
Contributor Author

Build fails because TaskProviderTest doesn't compile.
The project builds locally for me, so it looks like that compiling androidTest classes is not part of the default build task (gradlew build).
image

I am going to fix this now.

@lemonboston
Copy link
Contributor Author

lemonboston commented Nov 29, 2017

Travis build has failed twice now with this:

Skipping device 'test(AVD)' for 'opentasks:': Unknown API Level

 > : No compatible devices connected.[TestRunner] �[31mFAILED �[0m
Found 1 connected device(s), 0 of which were compatible.
:opentasks:connectedDebugAndroidTest FAILED

FAILURE: Build failed with an exception.

Not sure how to fix this. It seems it can't determine the API Level of the emulator. And only sometimes?
I am going to restart the build for a 3rd time now.

@dmfs
Copy link
Owner

dmfs commented Nov 29, 2017

I already created an issue for that: #516

@lemonboston
Copy link
Contributor Author

I saw that but the message copied there is different, I think that was an actual valid build fail for the TaskProviderTest.

@lemonboston
Copy link
Contributor Author

All checks pass here now, ready for review.

@NonNull
@Override
public View<TaskContract.Tasks> view(@NonNull ContentProviderClient client, @NonNull String... projection)
public View<TaskContract.Tasks> view(@NonNull ContentProviderClient client)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the annotations go?

Copy link
Owner

@dmfs dmfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dmfs dmfs merged commit 556281d into master Nov 29, 2017
@dmfs dmfs deleted the mx/517-update-contentpal-projection branch November 29, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants