Fix 12/24h format on event list due date-time by using an 5.1.1 Andro… #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id version of the DateUtils method. #396
|
How about using the workaround only if we have to. I.e. detect whether the device 24h/12h setting is different from the current locale 24h/12h setting and use the original method if it's the same? It's probably best if we use workarounds only to the extend we have to and stick to the original methods otherwise. |
…me format is 12 hour.
|
I've updated it as suggested, so only use old version when locale has AM/PM by default. Ready for check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…id version of the DateUtils method. #396
Fixed it as discussed on chat.
I just added the old version of the method as a private method of
DateFormatteras I assume it's best to keep every date-time formatting code there untilTimeis removed form the project. We can refactor after that.Btw, found the bug on the official tracker: https://issuetracker.google.com/issues/37127319