Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle and buildTools to latest. Suppress a new Lint error. #472 #481

Merged
merged 4 commits into from
Nov 21, 2017

Conversation

lemonboston
Copy link
Contributor

This updates gradle to latest. I've also added google() repository and a 'clean' task in the root gradle file which is added for some reason in new projects.

Lint marked this as error afterwards:
image

I suppressed it because I don't know what is expected there. @dmfs could you please check that? Can that binary flag operation be simplified or expressed differently?

@dmfs
Copy link
Owner

dmfs commented Nov 20, 2017

The update caused a problem with CI:

Checking the license for package Android SDK Build-Tools 26.0.2 in /usr/local/android-sdk/licenses

Warning: License for package Android SDK Build-Tools 26.0.2 not accepted.

Please make sure to update .travis.yml as well.

@dmfs
Copy link
Owner

dmfs commented Nov 20, 2017

Regarding the Lint warning: Apparently Lint can't handle bit arithmetic. Otherwise it would know that this operations "unsets" the given flag.
You can ignore the warning. We'll probably replace this code eventually with something cleaner.

@lemonboston
Copy link
Contributor Author

I've updated the build tools version in travis.yml so the push build now pass but the pr one fails with:

:opentasks:connectedDebugAndroidTest
Skipping device 'test(AVD)' for 'opentasks:': Unknown API Level
 > : No compatible devices connected.[TestRunner] FAILED 
Found 1 connected device(s), 0 of which were compatible.
:opentasks:connectedDebugAndroidTest FAILED

Do you happen to know what this is? I see some configuration for an emulator in the yml, the version looks correct.

@dmfs
Copy link
Owner

dmfs commented Nov 20, 2017

Not sure. Have you tried adding?

   - android-26

@lemonboston
Copy link
Contributor Author

One of the build still fails but due to #486
Otherwise this is ready for checking again.

@dmfs dmfs merged commit eb26147 into master Nov 21, 2017
@dmfs dmfs deleted the mx/472-update-gradle branch November 22, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants