Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .travis.yml. Implements #417 #466

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Add .travis.yml. Implements #417 #466

merged 1 commit into from
Oct 19, 2017

Conversation

dmfs
Copy link
Owner

@dmfs dmfs commented Oct 18, 2017

This also changes the version code to be based on commit count in the current branch rather than master. Apparently Travis doesn't fetch the master which caused this to fail.
Since we only publish master builds this should not have any unwanted side effects. Yet we spread the version code to allow inserting version numbers if necessary.

This also changes the version code to be based on commit count in the current branch rather than master. Apparently Travis doesn't fetch the master which caused this to fail.
Since we only publish master builds this should not have any unwanted side effects. Yet we spread the version code to allow inserting version numbers if necessary.
@dmfs dmfs requested a review from lemonboston October 18, 2017 21:04
Copy link
Contributor

@lemonboston lemonboston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice that we have CI set up on the project.

@dmfs
Copy link
Owner Author

dmfs commented Oct 19, 2017

Yeah, I'm not sure why the push build failed. Maybe there is some sort of timeout issue. We'll see how it works.

@dmfs dmfs merged commit 9aa367c into master Oct 19, 2017
@dmfs dmfs deleted the mx/417-travis-ci branch October 19, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants