Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Theme - Chapter I #879

Closed
dmfs opened this issue Nov 14, 2019 · 1 comment
Closed

Refactor Theme - Chapter I #879

dmfs opened this issue Nov 14, 2019 · 1 comment

Comments

@dmfs
Copy link
Owner

dmfs commented Nov 14, 2019

The current theme has been written long time ago without proper understanding of how themes work in Android. It's time to refactor the mess to make themes easier to work with. Several other theme related issues require this work.

At present the app uses multiple themes for different activities. Ideally there should be only one light theme use by all activities (and later on a dark theme as well).

In the first step we'll create a new theme OpenTasks_Theme.Light and update the TaskListActivity and SyncSettingsActivity to use it. This task is already big enough, so we'll cover the other activities in separate stories.

As part of this story the theme may be updated a bit.

@dmfs dmfs changed the title Refactor theme Refactor theme Chapter I Nov 14, 2019
@dmfs dmfs changed the title Refactor theme Chapter I Refactor Theme - Chapter I Nov 14, 2019
dmfs added a commit that referenced this issue Feb 6, 2021
This is an initial redesign and refactoring of the light theme. This also prepares for a future dark theme.

set statusbar color
dmfs added a commit that referenced this issue Feb 6, 2021
This is an initial redesign and refactoring of the light theme. This also prepares for a future dark theme.

set statusbar color
dmfs added a commit that referenced this issue Feb 6, 2021
This is an initial redesign and refactoring of the light theme. This also prepares for a future dark theme.

set statusbar color
dmfs added a commit that referenced this issue Feb 6, 2021
This is an initial redesign and refactoring of the light theme. This also prepares for a future dark theme.
The new theme was separated into a new module so we can share it among modules.
@dmfs
Copy link
Owner Author

dmfs commented Mar 8, 2021

done

@dmfs dmfs closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant